test(fuzz): fix broken OSS-Fuz build #21940
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| diff --git a/types/address_test.go b/types/address_test.go | ||
| index 014a48b73..99f9a1a86 100644 | ||
| --- a/types/address_test.go | ||
| +++ b/types/address_test.go | ||
| @@ -26,10 +26,6 @@ type addressTestSuite struct { | ||
| suite.Suite | ||
| } | ||
|
|
||
| -func TestAddressTestSuite(t *testing.T) { | ||
| - suite.Run(t, new(addressTestSuite)) | ||
| -} | ||
| - | ||
| func (s *addressTestSuite) SetupSuite() { | ||
| s.T().Parallel() | ||
| } | ||
| @@ -403,65 +399,6 @@ func (s *addressTestSuite) TestAddressInterface() { | ||
| } | ||
| } | ||
|
|
||
| -func (s *addressTestSuite) TestBech32ifyAddressBytes() { | ||
| - type args struct { | ||
| - prefix string | ||
| - bs []byte | ||
| - } | ||
| - tests := []struct { | ||
| - name string | ||
| - args args | ||
| - want string | ||
| - wantErr bool | ||
| - }{ | ||
| - {"empty address", args{"prefixa", []byte{}}, "", false}, | ||
| - {"empty prefix", args{"", addr20byte}, "", true}, | ||
| - {"10-byte address", args{"prefixa", addr10byte}, "prefixa1qqqsyqcyq5rqwzqf3953cc", false}, | ||
| - {"10-byte address", args{"prefixb", addr10byte}, "prefixb1qqqsyqcyq5rqwzqf20xxpc", false}, | ||
| - {"20-byte address", args{"prefixa", addr20byte}, "prefixa1qqqsyqcyq5rqwzqfpg9scrgwpugpzysn7hzdtn", false}, | ||
| - {"20-byte address", args{"prefixb", addr20byte}, "prefixb1qqqsyqcyq5rqwzqfpg9scrgwpugpzysnrujsuw", false}, | ||
| - } | ||
| - for _, tt := range tests { | ||
| - s.T().Run(tt.name, func(t *testing.T) { | ||
| - got, err := types.Bech32ifyAddressBytes(tt.args.prefix, tt.args.bs) | ||
| - if (err != nil) != tt.wantErr { | ||
| - t.Errorf("Bech32ifyBytes() error = %v, wantErr %v", err, tt.wantErr) | ||
| - return | ||
| - } | ||
| - require.Equal(t, tt.want, got) | ||
| - }) | ||
| - } | ||
| -} | ||
| - | ||
| -func (s *addressTestSuite) TestMustBech32ifyAddressBytes() { | ||
| - type args struct { | ||
| - prefix string | ||
| - bs []byte | ||
| - } | ||
| - tests := []struct { | ||
| - name string | ||
| - args args | ||
| - want string | ||
| - wantPanic bool | ||
| - }{ | ||
| - {"empty address", args{"prefixa", []byte{}}, "", false}, | ||
| - {"empty prefix", args{"", addr20byte}, "", true}, | ||
| - {"10-byte address", args{"prefixa", addr10byte}, "prefixa1qqqsyqcyq5rqwzqf3953cc", false}, | ||
| - {"10-byte address", args{"prefixb", addr10byte}, "prefixb1qqqsyqcyq5rqwzqf20xxpc", false}, | ||
| - {"20-byte address", args{"prefixa", addr20byte}, "prefixa1qqqsyqcyq5rqwzqfpg9scrgwpugpzysn7hzdtn", false}, | ||
| - {"20-byte address", args{"prefixb", addr20byte}, "prefixb1qqqsyqcyq5rqwzqfpg9scrgwpugpzysnrujsuw", false}, | ||
| - } | ||
| - for _, tt := range tests { | ||
| - s.T().Run(tt.name, func(t *testing.T) { | ||
| - if tt.wantPanic { | ||
| - require.Panics(t, func() { types.MustBech32ifyAddressBytes(tt.args.prefix, tt.args.bs) }) | ||
| - return | ||
| - } | ||
| - require.Equal(t, tt.want, types.MustBech32ifyAddressBytes(tt.args.prefix, tt.args.bs)) | ||
| - }) | ||
| - } | ||
| -} | ||
|
Comment on lines
+50
to
+77
There was a problem hiding this comment. 💡 Codebase verification Additional tests for The removal of
🔗 Analysis chainVerify coverage for MustBech32ifyAddressBytes functionality The removal of Let's verify if this functionality is tested elsewhere: If no other tests are found, consider adding a minimal test for 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for other tests covering MustBech32ifyAddressBytes functionality
# Search for other tests of MustBech32ifyAddressBytes
echo "Searching for other tests of MustBech32ifyAddressBytes:"
rg --type go 'func Test.*MustBech32ifyAddressBytes'
# Look for usage of MustBech32ifyAddressBytes in the codebase
echo "Checking usage of MustBech32ifyAddressBytes:"
rg --type go 'MustBech32ifyAddressBytes'
Length of output: 943 |
||
| - | ||
| func (s *addressTestSuite) TestAddressTypesEquals() { | ||
| addr1 := secp256k1.GenPrivKey().PubKey().Address() | ||
| accAddr1 := types.AccAddress(addr1) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Potential Test Coverage Reduction Due to Removal of Test Suite Runner
The
TestAddressTestSuitefunction has been removed, and no alternative test suite runners were found for address-related tests. While individual tests likeTestBech32ifyAddressBytesstill exist intypes/address_test.go, their execution may be compromised without a suite runner, potentially reducing overall test coverage.🔗 Analysis chain
Verify the impact of removing TestAddressTestSuite
The removal of
TestAddressTestSuitefunction, which was responsible for running the entire address test suite, could significantly impact the test coverage. While this might be necessary to fix the OSS-Fuzz build as per the PR objectives, we need to ensure that critical tests are still being run elsewhere.Let's verify if there are other test suite runners or if these tests are covered elsewhere:
Consider adding a comment explaining why these tests were removed and how the functionality is being tested now, if applicable. This will help maintain clarity for future developers working on this code.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 7093