-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cpp headers over system headers #221
Conversation
The formatting script is sorting the headers and re-wrapped some lines in base.cc and double.cc. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ? : style doesn't look like most of the OpenASIP codebase and newlib should be left with minimal modifications, otherwise LGTM.
openasip/newlib-1.17.0/newlib/libc/sys/linux/linuxthreads/machine/i386/useldt.h
Outdated
Show resolved
Hide resolved
Fixes applied |
openasip/newlib-1.17.0/newlib/libc/sys/linux/linuxthreads/machine/i386/useldt.h
Outdated
Show resolved
Hide resolved
Update to cpp headers (formatted) Use c++ headers in c++ files Reverts change Rework on clean copies from main
49e4849
to
a0b8a6f
Compare
Changes in the force-pushed update:
|
Did you run the tests? There seem to be a couple of cases which are compiled with the oacc's (incomplete C++ support), which doesn't yet have a stdlib.
Here's the info for how to run the tests if you haven't before: https://github.com/cpc/openasip/wiki/Contributor-Info |
Thank you. I had been running tests from the test directory and missed that there's a test driver script. It's also flagging problems I hadn't seen earlier. This may take some time, as compiletest isn't passing on a fresh checkout of the project. |
Filed #223 which is blocking resolution of the above question. |
I'm going to close this for now and come back when I have a reliable testing setup. |
This replaces system headers such as
<math.h>
with the corresponding C++ header (<cmath>
) ni C++ code.Each of the compiler suites includes its own c++ headers, and there's a risk of the system headers differing from these and causing subtle bugs.