(Re-)add support for remote repositories #77
Conversation
|
Formatting check succeeded! |
| @@ -234,22 +231,24 @@ public Integer call() throws Exception { | |||
| return 0; | |||
| } | |||
|
|
|||
| private Repository createRepository(FhirContext fhirContext, Path terminologyPath, Path modelPath) { | |||
| private Repository createRepository(FhirContext fhirContext, String terminologyUrl, String modelUrl) { | |||
There was a problem hiding this comment.
Even though behavior around the terminology path is not affected by this change, I've made it a String as well for consistency. createRepository is now responsible for turning the given URLs, if present, into the appropriate form for a repository.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature-remote-execution #77 +/- ##
==============================================================
+ Coverage 36.24% 44.48% +8.24%
- Complexity 139 157 +18
==============================================================
Files 39 39
Lines 1018 1016 -2
Branches 110 111 +1
==============================================================
+ Hits 369 452 +83
+ Misses 612 512 -100
- Partials 37 52 +15 ☔ View full report in Codecov by Sentry. |
|
Will we need support for remote terminology as well? Is that worth adding as part of this PR? |
* WIP on master Wire up expression to the actual engine evaluation * Run spotless * Remove irrelevant tests * Restore test --------- Co-authored-by: Holly Wu <holly.wu@smiledigitalhealth.com>
| } | ||
|
|
||
| // @Test | ||
| // void withRemoteModel() { |
There was a problem hiding this comment.
This requires us to stand up a dummy HTTP server which is a rabbit hole I'm not gonna go down now, but this test does work locally with a FHIR server running, so it still has some value.
Support for remote execution of CQL is already supported by the language server; this PR re-exposes that functionality.