-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Esp32 Core version 3 #2144
base: master
Are you sure you want to change the base?
Esp32 Core version 3 #2144
Conversation
Feature: Make IRremoteESP8266 compatible with IDF 5.x ESP32 Version 3 |
@NiKiZe code is running on ESP32 S3 With ESP32 Version 3.0.4 without any errors I will try to test with ESP32-DEV & ESP32-C6 this weak |
As I understand it, so is #2040, we are grateful for your PR. Just want to limit duplication if there already is a fully working implementation. |
#2040 is working perfectly fine. |
@Jason2866 - #2040 isn't working on the M5Stack NanoC6 under Arduino IDE. Have commented on the relevant PR I'm able to decode my remote using this pull request |
@Jason2866 Tested with ESP32-C6 WROOM1, ESP32 WROVER and the code is working on Esp32 Core version 3. |
@NiKiZe @Jason2866 Thank you for feedback did the required changes |
I would suggest this: https://github.com/crankyoldgit/IRremoteESP8266/compare/master...NiKiZe:IRremoteESP8266:ForPr2144?expand=1 Or to see my suggestions on their own: 4ef02e5 I would like to improve on the |
I have updated and pushed "reverts" of lines that don't need change. (mostly indentation and comments) @crankyoldgit if you have the time I would especially like your input of how to deal with the comments on |
e23c19e
to
f858d28
Compare
Hi @NiKiZe @crankyoldgit @Jason2866, |
@NiKiZe @crankyoldgit I made changes as you request not if failing on code Lint but not sure if it because of me. |
This works for me on wemos d1 mini32. |
Fixes #2039