Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esp32 Core version 3 #2144

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

BorisKofman
Copy link
Contributor

@BorisKofman BorisKofman commented Sep 6, 2024

Fixes #2039

@NiKiZe
Copy link
Collaborator

NiKiZe commented Sep 6, 2024

Duplicate of #2040 / #2039 ?

But please provide an explanation if this has any improvements over the other.

@BorisKofman BorisKofman closed this Sep 8, 2024
@BorisKofman BorisKofman deleted the Espressif-version-3 branch September 8, 2024 11:09
@BorisKofman BorisKofman restored the Espressif-version-3 branch September 8, 2024 11:19
@BorisKofman BorisKofman reopened this Sep 8, 2024
@BorisKofman
Copy link
Contributor Author

Feature:

Make IRremoteESP8266 compatible with IDF 5.x ESP32 Version 3

@BorisKofman
Copy link
Contributor Author

BorisKofman commented Sep 8, 2024

@NiKiZe code is running on ESP32 S3 With ESP32 Version 3.0.4 without any errors

I will try to test with ESP32-DEV & ESP32-C6 this weak

@NiKiZe
Copy link
Collaborator

NiKiZe commented Sep 8, 2024

As I understand it, so is #2040, we are grateful for your PR. Just want to limit duplication if there already is a fully working implementation.

@BorisKofman
Copy link
Contributor Author

Thanks @NiKiZe,
With #2040 I get error: timer is not enabled yet
I will try to test my Code with IDF 5.x and much Boards that I can
Currently tested "IDF 5.X" with S3.
Tomorrow will try with C6 and esp32-dev.
Then I will revert to ESP32 board version 2 to test again with S3 & DEV boards
Thanks!

src/IRrecv.cpp Outdated Show resolved Hide resolved
@Jason2866
Copy link

#2040 is working perfectly fine.

@Buddy-Matt
Copy link

Buddy-Matt commented Sep 16, 2024

@Jason2866 - #2040 isn't working on the M5Stack NanoC6 under Arduino IDE. Have commented on the relevant PR

I'm able to decode my remote using this pull request

@BorisKofman
Copy link
Contributor Author

@Jason2866 Tested with ESP32-C6 WROOM1, ESP32 WROVER and the code is working on Esp32 Core version 3.
Thanks!

src/IRrecv.cpp Outdated Show resolved Hide resolved
@BorisKofman BorisKofman requested a review from NiKiZe September 17, 2024 10:54
@BorisKofman
Copy link
Contributor Author

@NiKiZe @Jason2866 Thank you for feedback did the required changes
Thanks!

src/IRrecv.cpp Outdated Show resolved Hide resolved
src/IRrecv.cpp Outdated Show resolved Hide resolved
NiKiZe added a commit to NiKiZe/IRremoteESP8266 that referenced this pull request Sep 17, 2024
NiKiZe added a commit to NiKiZe/IRremoteESP8266 that referenced this pull request Sep 17, 2024
NiKiZe added a commit to NiKiZe/IRremoteESP8266 that referenced this pull request Sep 17, 2024
NiKiZe added a commit to NiKiZe/IRremoteESP8266 that referenced this pull request Sep 17, 2024
NiKiZe added a commit to NiKiZe/IRremoteESP8266 that referenced this pull request Sep 17, 2024
NiKiZe added a commit to NiKiZe/IRremoteESP8266 that referenced this pull request Sep 17, 2024
@NiKiZe
Copy link
Collaborator

NiKiZe commented Sep 17, 2024

I would suggest this: https://github.com/crankyoldgit/IRremoteESP8266/compare/master...NiKiZe:IRremoteESP8266:ForPr2144?expand=1

Or to see my suggestions on their own: 4ef02e5

I would like to improve on the #ifdef logic further and maybe rename the old HACK one as will, but maybe not in this PR.

@BorisKofman BorisKofman requested a review from NiKiZe September 19, 2024 06:01
NiKiZe added a commit to NiKiZe/IRremoteESP8266 that referenced this pull request Sep 23, 2024
@NiKiZe
Copy link
Collaborator

NiKiZe commented Sep 23, 2024

I have updated and pushed "reverts" of lines that don't need change. (mostly indentation and comments)
Modified the corev3 define to follow the pattern of others, and also tried a rename.

@crankyoldgit if you have the time I would especially like your input of how to deal with the comments on #elif and #endif for these cases.

@NiKiZe NiKiZe requested review from crankyoldgit and removed request for Jason2866 September 23, 2024 12:33
src/IRrecv.cpp Outdated Show resolved Hide resolved
src/IRrecv.cpp Outdated Show resolved Hide resolved
src/IRrecv.cpp Outdated Show resolved Hide resolved
src/IRrecv.cpp Outdated Show resolved Hide resolved
@NiKiZe NiKiZe force-pushed the Espressif-version-3 branch from e23c19e to f858d28 Compare September 23, 2024 14:48
@BorisKofman
Copy link
Contributor Author

Hi @NiKiZe @crankyoldgit @Jason2866,
I in middle of vacation and can't update your request.
Maybe someone please can finish it or I will try to finishing next weak.
Thanks!

@BorisKofman
Copy link
Contributor Author

@NiKiZe @crankyoldgit I made changes as you request not if failing on code Lint but not sure if it because of me.

@hendriksen-mark
Copy link

This works for me on wemos d1 mini32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Support for esp32 Arduino 3.0.0
6 participants