Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: This and that #568

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Maintenance: This and that #568

merged 2 commits into from
Jul 31, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Jul 30, 2023

About

Update documentation content

  • Add missing credits to change log
  • Update to crate-docs 2.1.1
  • Improve wording
  • Update intersphinx reference to SQLAlchemy 2.x

Satisfy linter admonition flake8 E721

The admonition was:

E721 do not compare types, for exact checks use is / is not, for instance checks use isinstance().

Apparently, it has been added to flake8 6.1.0, released on July 29, 2023.

- Add missing credits to change log
- Update to crate-docs 2.1.1
- Improve wording
- Update intersphinx reference to SQLAlchemy 2.x
The admonition was: E721 do not compare types, for exact checks use
`is` / `is not`, for instance checks use `isinstance()`.

Apparently, it has been added to flake8 6.1.0, released on July 29, 2023
@amotl amotl requested review from matriv and hlcianfagna July 30, 2023 14:52
@amotl amotl marked this pull request as ready for review July 30, 2023 15:03
@amotl amotl merged commit d2d44a5 into master Jul 31, 2023
28 checks passed
@amotl amotl deleted the amo/this-and-that branch July 31, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants