-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement API for converting Picture to BufferedImage #144
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
/* | ||
* Copyright 2015 Creative Scala | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package doodle | ||
package syntax | ||
|
||
import cats.effect.IO | ||
import cats.effect.unsafe.IORuntime | ||
import doodle.algebra.Algebra | ||
import doodle.algebra.Picture | ||
import doodle.effect.BufferedImageConverter | ||
import doodle.core.format.Format | ||
import java.awt.image.BufferedImage | ||
|
||
trait BufferedImageConverterSyntax { | ||
implicit class BufferedImageConverterOps[Alg <: Algebra, A]( | ||
picture: Picture[Alg, A] | ||
) { | ||
class BufferedImageConverterOpsHelper[Fmt <: Format]( | ||
picture: Picture[Alg, A] | ||
) { | ||
def apply[Frame](frame: Frame)(implicit | ||
w: BufferedImageConverter[Alg, Frame, Fmt], | ||
r: IORuntime | ||
): (A, BufferedImage) = | ||
w.bufferedImage(frame, picture).unsafeRunSync() | ||
} | ||
|
||
class BufferedImageConverterIOOpsHelper[Fmt <: Format]( | ||
picture: Picture[Alg, A] | ||
) { | ||
def apply[Frame](frame: Frame)(implicit | ||
w: BufferedImageConverter[Alg, Frame, Fmt], | ||
r: IORuntime | ||
): IO[(A, BufferedImage)] = | ||
w.bufferedImage(frame, picture) | ||
} | ||
|
||
def bufferedImage[Fmt <: Format] = | ||
new BufferedImageConverterOpsHelper[Fmt](picture) | ||
|
||
def bufferedImageToIO[Fmt <: Format] = | ||
new BufferedImageConverterIOOpsHelper[Fmt](picture) | ||
} | ||
} |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this compile on the Javascript platform? E.g. does I suspect the
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You are probably right. I was just following what |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/* | ||
* Copyright 2015 Creative Scala | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package doodle | ||
package effect | ||
|
||
import cats.effect.IO | ||
import doodle.algebra.Algebra | ||
import doodle.algebra.Picture | ||
import java.awt.image.BufferedImage | ||
import doodle.core.format.Format | ||
|
||
trait BufferedImageConverter[+Alg <: Algebra, Frame, Fmt <: Format] { | ||
def bufferedImage[A]( | ||
description: Frame, | ||
picture: Picture[Alg, A] | ||
): IO[(A, BufferedImage)] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the
Fmt
type is needed. This type specifies a file format (like PNG or JPEG), which is not relevant for saving to an in-memory bitmap.If the
Fmt
types goes the helper classes are no longer necessary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added the format becuase the
renderBufferedImage()
requires amakeImage()
function which defined for eachJava2d[Format]Writer
objectShould I just create a separate object for the
BufferedImageConverter
with its ownmakeImage()
function and make this the only implicitBufferedImageConverter
?