Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DefaultFrame type class #153

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Implement DefaultFrame type class #153

merged 5 commits into from
Mar 20, 2024

Conversation

noelwelsh
Copy link
Contributor

Closes #148

- Implement DefaultFrame to provide a default frame for other effects
that need one

- Remove DefaultRenderer as DefaultFrame replaces its functionality in a
more general way

- Update other code as necessary

- Add some documentation

Closes #148
@noelwelsh noelwelsh mentioned this pull request Mar 20, 2024
3 tasks
@noelwelsh noelwelsh requested a review from jCabala March 20, 2024 17:49
Copy link
Collaborator

@jCabala jCabala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. What is the purpose of this CI changes?

@noelwelsh
Copy link
Contributor Author

The CI needs to be updated when certain parts of the build change.

@noelwelsh noelwelsh merged commit 1d9c0c0 into main Mar 20, 2024
10 checks passed
@noelwelsh noelwelsh deleted the feature/default-frame branch March 20, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abstract default frame
2 participants