MySQL 8.0 support: prefix AsBinary and GeomFromText with "ST_"

[holtkamp]

No description provided.

[holtkamp]

As discussed in: #193 and #190

[coveralls]

Coverage decreased (-17.7%) to 80.357% when pulling 9ab5d68 on holtkamp:mysql-80-support into 58ea5fa on creof:master.

[coveralls]

Coverage decreased (-43.6%) to 54.447% when pulling 034edaa on holtkamp:mysql-80-support into 58ea5fa on creof:master.

[coveralls]

Coverage decreased (-17.7%) to 80.357% when pulling 9ab5d68 on holtkamp:mysql-80-support into 58ea5fa on creof:master.

[coveralls]

Coverage decreased (-17.7%) to 80.357% when pulling 9ab5d68 on holtkamp:mysql-80-support into 58ea5fa on creof:master.

[coveralls]

Coverage decreased (-17.7%) to 80.357% when pulling 9ab5d68 on holtkamp:mysql-80-support into 58ea5fa on creof:master.

[coveralls]

Coverage decreased (-17.7%) to 80.357% when pulling 9ab5d68 on holtkamp:mysql-80-support into 58ea5fa on creof:master.

[holtkamp]

It seems the automated tests are broken, but not due to this PR

[holtkamp]

Minor bump on this?

[SebastienTainon]

That would be great if it could be merged indeed, as Mysql 8.0 is getting used more and more by the community.

[spackmat]

Ubuntu 20.04 is out with MySQL 8, so that would be a good occasion to release a version supporting that.

[sadortun]

Anyone here that can give it a try and test the lib ?

[spackmat]

Yesterday I only prefixed the two function calls with 'ST_' to get rid of the SQL error in my application. That works fine and fixes the error.

[samwilson]

I've tested this patch on mariadb 10.3 and mysql 8.0 and it's good (if that's of any help :-P).

@spackmat how did you do that?

[spackmat]

@spackmat how did you do that?

I don't remember exactly, but I think I patched the lines containing 'ST_' manually. But I cannot find that in my code. A week later was the moment, I migrated to MariaDB 10.3 and the problem was gone.

[samwilson]

I don't remember exactly, but I think I patched the lines containing 'ST_' manually. But I cannot find that in my code. A week later was the moment, I migrated to MariaDB 10.3 and the problem was gone.

Yeah it seems fine in MariaDB. Maybe I should just give up on MySQL. :) For now I'm using this patch (via a Composer repository).

[behalp]

After switch to new computer with mysql 8.0.22 I got problems with missing AsBinary function, I just prefixed ST_ in lib\CrEOF\Spatial\DBAL\Platform\mysql.php for this function and this fixed it. I made same change in older PC where is 5.6.45 and there it was working as well. I would like to get this fix merged.

[samwilson]

The alexandret/doctrine2-spatial fork includes this; I've switched to that until this is fixed here.

[behalp]

Thank you, I will switch to this as well for now. st 13. 1. 2021 v 0:18 odesílatel Sam Wilson <notifications@github.com> napsal:

…

The alexandret/doctrine2-spatial fork includes this; I've switched to that until this is fixed here. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#196 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKBHAWEMUJNN46K7QVNZMMDSZTKDNANCNFSM4GKTH5IA> .