Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect timeout log on evaluate requests #442

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

Fryuni
Copy link
Member

@Fryuni Fryuni commented Dec 5, 2024

Summary

  • Assign the timer to the variable so it can be cancelled when the request is completed
  • Fix testing to include the time change to avoid regressions

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@Fryuni Fryuni requested a review from marcospassos December 5, 2024 21:48
@Fryuni Fryuni self-assigned this Dec 5, 2024
@Fryuni Fryuni added the bug Something isn't working label Dec 5, 2024
Copy link

pkg-pr-new bot commented Dec 5, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@croct/sdk@442

commit: 82acd59

@marcospassos marcospassos merged commit 8db161a into master Dec 5, 2024
8 checks passed
@marcospassos marcospassos deleted the fix/evaluation-timeout-log branch December 5, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants