Refactor collections and collection property access. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crud89
added
Requirement
|
Blocked until |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR improves interfaces and collection handling. The
Enumerablecontainer has been replaced in favor ofstd::generatorand where possible references to the underlying arrays are returned. The basic design principle is to useEnumerablewhere no guarantee about the storage of elements can be made, i.e. where further transformation or filter is applied to a container before returning from it. If the array property maps to a contains relationship, the a reference to the array type is returned instead (which can hardly be beaten in terms of performance). Interfaces use generators to convert the concrete representation into interface pointers and yield them using this interface, so it is (as expected) most efficient to call specialized classes where possible. For inputs, generators can be used to create lazy-evaluated data streams. In some places, overloads have been added that allow to supply both: generators or spans.