Add first benchmark #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add AGPLv3 licensed fork of libcrux crates
jschneider-bensch
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Looks great, thanks! Just some doc-related nits.
And, could you rebase on main or merge main? I thought it had done that automatically when updating the PR target, but from the diff it looks like e.g. memory.x and mldsa_65.rx don't use the current main version to merge 🤷 .
Co-authored-by: Jonas Schneider-Bensch <jonas@cryspen.com>
keks
force-pushed
the
keks/first-benchmark
branch
from
e11f0a7 to
d96ef61
Compare
|
Thanks! |
jschneider-bensch
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the benchmark tooling and runs the benchmarks for ML_DSA65 on the Nucleo144 board.
We still have plans to make this more convenient to use, but this is a good starting point that works.
This PR sits on top of #19 as it is needed to getting the benchmarks to run in the first place.