Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate crate for tests and benchmarks #22

Merged
merged 13 commits into from
Nov 6, 2024
Merged

Separate crate for tests and benchmarks #22

merged 13 commits into from
Nov 6, 2024

Conversation

jschneider-bensch
Copy link
Contributor

@jschneider-bensch jschneider-bensch commented Oct 16, 2024 •
edited
Loading

To avoid duplication of test and benchmark code, I've pulled these out into a separate crate, which the board-specific crates depend on.

Fixes #20

Base automatically changed from keks/first-benchmark to main October 16, 2024 11:04
@jschneider-bensch jschneider-bensch marked this pull request as ready for review October 16, 2024 11:06
keks
keks reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@keks keks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is pretty much was we discussed. There were a few things I didn't quite understand, and one point where I think the design could be improved (without much effort).

libcrux-testbench/src/lib.rs Show resolved Hide resolved
libcrux-testbench/src/mldsa.rs Outdated Show resolved Hide resolved
libcrux-testbench/src/mldsa.rs Outdated Show resolved Hide resolved
libcrux-testbench/src/mldsa.rs Outdated Show resolved Hide resolved
libcrux/libcrux-platform/src/lib.rs Show resolved Hide resolved
keks
keks approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@keks keks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! Sorry this took so long 🙈

@jschneider-bensch jschneider-bensch merged commit 387f04f into main Nov 6, 2024
4 checks passed
@jschneider-bensch jschneider-bensch deleted the jonas/testbench-crate branch November 6, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keks keks keks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate nRF52840 crate to embassy-nrf
2 participants
@jschneider-bensch @keks