Crates for our Nordic boards #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d8178dc.
franziskuskiefer
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds board-specific crates for our Nordic boards, specifically
libcrux-nrf5340libcrux-nrf52810&libcrux-nrf52832for the nRF52-DK, which can test both of these SoCsI've also added preliminary results for some of the boards in
benchmarks.md.For the nRF52810 we're operating with 192KB of flash, which is not enough to fit the MLDSA benchmark we use for the other boards. For this reason I've opted to not use the testutil there and build individual binaries for keygen, signing and verification. It also has just 24KB of RAM so, while this allows us to build and link the binaries, we'll have to put in more work reducing stack sizes before we can hope to actually run the operations on that device.