This repository has been archived by the owner on May 20, 2019. It is now read-only.
Date #38
Open
Date #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
colbyguan
suggested changes
Nov 6, 2016
| @@ -24,12 +24,12 @@ | |||
| <tr class="student-list"> | |||
| <td class="col-md-2"> | |||
| <div> | |||
| <a class="btn btn-success" data-toggle="collapse" href="#coursecollapse<%=student.id%>" href="#" role="button"><i class="fa fa-plus"></i></a> <a class="btn btn-warning" data-toggle="collapse" href="#editcollapse<%=student.id%>" role="button"><i class="fa fa-pencil-square-o"></i></a> | |||
| <a class="btn btn-success" style="height:30px; width:30px; position:relative; text-align:center; line-height:1em; padding-left:9px;" data-toggle="collapse" href="#coursecollapse<%=student.id%>" href="#" role="button"><i class="fa fa-plus"></i></a> <a class="btn btn-warning" style="height:30px;width:30px;text-align:center;line-height:1em;padding-left:9px;" data-toggle="collapse" href="#editcollapse<%=student.id%>" role="button"><i class="fa fa-pencil-square"></i></a> | |||
There was a problem hiding this comment.
Few things:
- Could you put these under the same class and move the style to admin's CSS file?
- I like the size that the buttons are now, but a single row still takes about the same amount of space as it did before. We can probably fit more students on one screen with all buttons on the same row + splitting up the student's name and email into separate columns. Something like:
[+] [/] [o] [x] | Name | email@domain.com - Since we're including the Manage Students changes here, adding mouseover Bootstrap tooltips for what each of the 4 buttons do would be pretty useful (and requested by users).
| <div class="list-group-item"> | ||
| <h3 class="list-group-item-heading">Week <%= n %></h3> | ||
| <h3 class="list-group-item-heading">Week <%= n %>: <%= month_increment %> <%= monthArray[current_month] %> <%= current_day %> <%= start_hour.strftime("%I:%M") %> to <%= end_hour.strftime("%I:%M") %></h3> |
There was a problem hiding this comment.
Looks good except for a few things:
- What is month_increment? It seems to be an unnecessary number to display.
- No need to show the time range of the sections, that's already in the previous view that leads to the attendance view.
added 4 commits
November 6, 2016 11:15
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.