Skip to content
This repository has been archived by the owner on May 20, 2019. It is now read-only.

Date #38

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Date #38

wants to merge 7 commits into from

Conversation

nirajrao
Copy link

No description provided.

@nirajrao
Copy link
Author

  • Updated Attendance Section (Month/Day) so that it appears for each weekly section.
  • Shrunk the icons in the Manage Students Admin Section.

@@ -24,12 +24,12 @@
<tr class="student-list">
<td class="col-md-2">
<div>
<a class="btn btn-success" data-toggle="collapse" href="#coursecollapse<%=student.id%>" href="#" role="button"><i class="fa fa-plus"></i></a> <a class="btn btn-warning" data-toggle="collapse" href="#editcollapse<%=student.id%>" role="button"><i class="fa fa-pencil-square-o"></i></a>
<a class="btn btn-success" style="height:30px; width:30px; position:relative; text-align:center; line-height:1em; padding-left:9px;" data-toggle="collapse" href="#coursecollapse<%=student.id%>" href="#" role="button"><i class="fa fa-plus"></i></a> <a class="btn btn-warning" style="height:30px;width:30px;text-align:center;line-height:1em;padding-left:9px;" data-toggle="collapse" href="#editcollapse<%=student.id%>" role="button"><i class="fa fa-pencil-square"></i></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things:

  1. Could you put these under the same class and move the style to admin's CSS file?
  2. I like the size that the buttons are now, but a single row still takes about the same amount of space as it did before. We can probably fit more students on one screen with all buttons on the same row + splitting up the student's name and email into separate columns. Something like:
    [+] [/] [o] [x] | Name | email@domain.com
  3. Since we're including the Manage Students changes here, adding mouseover Bootstrap tooltips for what each of the 4 buttons do would be pretty useful (and requested by users).

<div class="list-group-item">
<h3 class="list-group-item-heading">Week <%= n %></h3>
<h3 class="list-group-item-heading">Week <%= n %>: <%= month_increment %> <%= monthArray[current_month] %> <%= current_day %> <%= start_hour.strftime("%I:%M") %> to <%= end_hour.strftime("%I:%M") %></h3>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for a few things:

  • What is month_increment? It seems to be an unnecessary number to display.
  • No need to show the time range of the sections, that's already in the previous view that leads to the attendance view.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants