Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a bug where the attachments are extracted from the context too early, this prevented AfterStep from making attachments #637

Merged
merged 13 commits into from
Jul 23, 2024

Conversation

Johnlon
Copy link
Member

@Johnlon Johnlon commented Jul 23, 2024

🤔 What's changed?

fixed a bug where the attachments are extracted from the context too early, this prevented AfterStep from making attachments

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • [ x] I've changed the behaviour of the code
    • [ x] I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Johnlon and others added 13 commits June 26, 2024 02:50
…t yet recorded in the reports as 'Ambiguous', and no test cases figured out yet
… take a look at how cuke jvm report ambiguous steps and sets the step status to 'ambiguous' rather than my current solution which just blows the test up as a regular step error
Co-authored-by: Viacheslav Poturaev <nanopeni@gmail.com>
…early, this prevented AfterStep from making attachments
@Johnlon Johnlon merged commit 901da7f into cucumber:main Jul 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant