Skip to content

Commit

Permalink
macos bug
Browse files Browse the repository at this point in the history
  • Loading branch information
cupcakearmy committed Apr 11, 2021
1 parent b17f5db commit 928b69b
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 13 deletions.
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,9 @@ Head to the [release page](https://github.com/cupcakearmy/unpixel/releases) and
3. `yarn dist` to build for all platforms

Alternatevly you can run `yarn build` and the `yarn electron-builder -m` for `macOS`, `-l` fir `linux` or `-w` for `windows`.

## RELEASE

1. Create a draft release with the new version. (e.g. tag with `v1.2.3`).
2. Push to master and github workflow will build and upload assets to the draft matching the version of `package.json` and draft.
3. When ready publish release.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"repository": {
"url": "https://github.com/cupcakearmy/unpixel"
},
"version": "1.0.4",
"version": "1.0.5",
"main": "./dist/back/index.js",
"scripts": {
"start": "electron .",
Expand Down
14 changes: 2 additions & 12 deletions src/back/banner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ export default class Banner {
},
width: 1200,
height: 600,
fullscreen: !DEV,
fullscreen: true,
simpleFullscreen: os.platform() === 'darwin',
}
this.window = new BrowserWindow(options)

Expand All @@ -59,17 +60,6 @@ export default class Banner {
if (DEV) {
this.window.webContents.toggleDevTools()
} else {
switch (os.platform()) {
case 'win32':
break
case 'linux':
break
case 'darwin':
this.window.setSimpleFullScreen(true)
this.window.setFullScreenable(false)
break
}
// this.window.maximize()
this.window.setAlwaysOnTop(true, 'floating', 99)
this.window.setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true })
this.window.setMovable(false)
Expand Down

0 comments on commit 928b69b

Please sign in to comment.