add tricrypto deployments #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-adds the original implementation back (CurveTricryptoOptimizedWETH.vy) which is the implementation that allows native token transfers. Adds an additional implementation contract (CurveTricryptoOptimized.vy) that disallows native token transfers, has exchange_received, does not expose claim_admin_fees, and fees are collected in individual tokens.
The original tricrypto-ng implementation CurveTricryptoOptimizedWETH is at index 0 of all factories. the new tricrypto-ng implementation CurveTricryptoOptimized is at index 1, but only for factories that are not on Ethereum. This is because of a small bug in the ethereum factory where there is no getter for pool's implementation contract address, but it exists for layer2 factories.
Users can still create AMM pools without native token transfers by setting _weth to zero address.