Feature: Textrules #247
Merged
Feature: Textrules #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n/(expected|resources)
- Passes `cargo test`. - Found bug in printer when violating lines contain multi-byte characters. - Missing updates to MANUAL.
- PDF tested with `make MANUAL-dev`.
The appearance of "Fail" can be confusing. Only used in development/unittests, not in normal runtime.
Now, all of the rulesets are fully implemented in rules, not with grep.
This was referenced May 23, 2023
Closed
|
Thank you for your great work! |
This was referenced Jun 9, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement textrules feature.
src/textrules/.src/rules/to `src/syntaxrules/. Dev Question: New class of rules,textrules, working on lines instead of syntax. #244testcases,build.rs, andsrc/main.rs.mdandbuild.rs.Other rules which could be written later:
definemacro names fit required/forbidden regex.textrules/style_textwidth, I noticed a bug in the printer where multi-byte characters in a violating line would cause the hint and reason to be indented too far.This PR includes a fix (a9def1b).
--exampleand--updatehas been validated locally, but there are no unittest for this (yet).To see the diff for just moving "rules" to "syntaxrules", I've made an intermediate branch:
#246
Note, I forgot to include the changes to
md/ruleset-*.mdandrulesets/*in this intermediate branch, sorry.To see the diff between that branch and this one, i.e. the real changes:
https://github.com/DaveMcEwan/svlint/compare/textrules-move...DaveMcEwan:svlint:textrules?expand=1