Merge pull request #877 from dangdangwalk/backend/DANG-1241

backend/DANG-1241: TAG 변수 스테이지간 공유하도록 변경
dangdangwalk · Aug 24, 2024 · 2b0c819 · 2b0c819
2 parents 47d61e8 + 9f23ab0
commit 2b0c819
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/backend_weather_deploy.yaml b/.github/workflows/backend_weather_deploy.yaml
@@ -16,6 +16,8 @@ jobs:
     defaults:
       run:
         working-directory: ./backend/
+    outputs:
+      tag: ${{ steps.set_tag.outputs.tag }}
     steps:
       - name: Check out code
         uses: actions/checkout@v4
@@ -45,6 +47,7 @@ jobs:
           username: ${{secrets.DOCKERHUB_USERNAME}}
           password: ${{secrets.DOCKERHUB_TOKEN}}
       - name: Set TAG
+        id: set_tag
         run: echo "TAG=$(echo $GITHUB_SHA | cut -c1-7)" >> $GITHUB_ENV
       - name: Docker build
         run: |
@@ -85,9 +88,9 @@ jobs:
           fi
       - name: variables
         run: |
-          echo ${{ env.TAG }}
+          echo ${{ needs.build.outputs.tag }}
           echo ${{ env.IMAGE }}
       - name: run module
         run: |
           chmod +x /home/opc/run-weather.sh
-          /home/opc/run-weather.sh ${{ env.TAG }} .env.prod ${{ env.IMAGE }}
+          /home/opc/run-weather.sh ${{ needs.build.outputs.tag }} .env.prod ${{ env.IMAGE }}
diff --git a/backend/weather-api-module/src/data/data-factory.ts b/backend/weather-api-module/src/data/data-factory.ts
@@ -2,6 +2,7 @@ import { DataStore, getDataStore } from './data-store';
 
 let dataStoreInstance: DataStore | null = null;
 
+//TODO: erase
 export async function getDataInstance(): Promise<DataStore> {
     if (!dataStoreInstance) {
         dataStoreInstance = getDataStore();