forked from openwrt/openwrt
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
mediatek: fix PCIe #PERST being de-asserted too early
The driver for MediaTek gen3 PCIe hosts de-asserts all reset signals at the same time using a single register write operation. Delay the de-assertion of the #PERST signal by 100ms as some PCIe devices fail to come up otherwise. Signed-off-by: Daniel Golle <daniel@makrotopia.org>
- Loading branch information
Showing
3 changed files
with
37 additions
and
1 deletion.
There are no files selected for viewing
17 changes: 17 additions & 0 deletions
17
target/linux/mediatek/patches-5.15/611-pcie-mediatek-gen3-PERST-for-100ms.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
--- a/drivers/pci/controller/pcie-mediatek-gen3.c | ||
+++ b/drivers/pci/controller/pcie-mediatek-gen3.c | ||
@@ -319,7 +319,13 @@ static int mtk_pcie_startup_port(struct | ||
msleep(100); | ||
|
||
/* De-assert reset signals */ | ||
- val &= ~(PCIE_MAC_RSTB | PCIE_PHY_RSTB | PCIE_BRG_RSTB | PCIE_PE_RSTB); | ||
+ val &= ~(PCIE_MAC_RSTB | PCIE_PHY_RSTB | PCIE_BRG_RSTB); | ||
+ writel_relaxed(val, port->base + PCIE_RST_CTRL_REG); | ||
+ | ||
+ msleep(100); | ||
+ | ||
+ /* De-assert PERST# signals */ | ||
+ val &= ~(PCIE_PE_RSTB); | ||
writel_relaxed(val, port->base + PCIE_RST_CTRL_REG); | ||
|
||
/* Check if the link is up or not */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
target/linux/mediatek/patches-6.1/611-pcie-mediatek-gen3-PERST-for-100ms.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
--- a/drivers/pci/controller/pcie-mediatek-gen3.c | ||
+++ b/drivers/pci/controller/pcie-mediatek-gen3.c | ||
@@ -350,9 +350,15 @@ static int mtk_pcie_startup_port(struct | ||
msleep(100); | ||
|
||
/* De-assert reset signals */ | ||
- val &= ~(PCIE_MAC_RSTB | PCIE_PHY_RSTB | PCIE_BRG_RSTB | PCIE_PE_RSTB); | ||
+ val &= ~(PCIE_MAC_RSTB | PCIE_PHY_RSTB | PCIE_BRG_RSTB); | ||
writel_relaxed(val, pcie->base + PCIE_RST_CTRL_REG); | ||
|
||
+ msleep(100); | ||
+ | ||
+ /* De-assert PERST# signals */ | ||
+ val &= ~(PCIE_PE_RSTB); | ||
+ writel_relaxed(val, port->base + PCIE_RST_CTRL_REG); | ||
+ | ||
/* Check if the link is up or not */ | ||
err = readl_poll_timeout(pcie->base + PCIE_LINK_STATUS_REG, val, | ||
!!(val & PCIE_PORT_LINKUP), 20, |