Fix push not working #5214
Merged
Fix push not working #5214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new native mobile clients seem to use PascalCase for the push payload. Also the date/time could cause issues. This PR fixes this by formatting the date/time correctly and use PascalCase for the payload key's I now receive cipher updates and login-with-device requests again. Fixes dani-garcia#5182 Signed-off-by: BlackDex <black.dex@gmail.com>
dani-garcia
approved these changes
Nov 20, 2024
|
@BlackDex what happens when "old" clients are used? or do they ignore the case of the keys in the payload? |
|
@tessus, those also use PascalCase too. |
|
thx for the info |
|
I still not receive push notification when I try to login with an other device. |
Please do not comment on closed PR's that it is not working. Because it could be multiple things.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new native mobile clients seem to use PascalCase for the push payload. Also the date/time could cause issues.
This PR fixes this by formatting the date/time correctly and use PascalCase for the payload key's I now receive cipher updates and login-with-device requests again.
Fixes #5182