Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shutdown error in TestXcuiTest() added in recent commit with new … #160

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Aug 10, 2022

  1. Fix shutdown error in TestXcuiTest() added in recent commit with new …

    …context support
    
    The new semantics of testmanagerd.RunXCUIWithBundleIdsCtx() are that if a context is passed, the context is supposed to have an associated cancel() method, which should be called to abort the method.  The XCU Test method its>
    
    Passing a context does not interract well with testmanagerd.CloseXCUITestRunner().  It appears that you should use one (the context) or the other (testmanagerd.CloseXCUITestRunner), not both.
    
    It's arguable that this warrants a separate test, one for each invocation technique.
    
    As it stands, I haven't run the test since I don't have wda available to install, but I can confirm this is an issue in the invocation made from main.go "runwda".
    briankrznarich committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    6a9f1dc View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2022

  1. Configuration menu
    Copy the full SHA
    9739502 View commit details
    Browse the repository at this point in the history