🌊 feat: add streaming support for o1 models #4760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Streaming with o1-mini and o1-preview work fine with OpenAI/OpenRouter but haven’t been tested with Azure OpenAI due to no API access. |
1 similar comment
|
Streaming with o1-mini and o1-preview work fine with OpenAI/OpenRouter but haven’t been tested with Azure OpenAI due to no API access. |
danny-avila
approved these changes
Nov 20, 2024
danny-avila
changed the title
owengo
pushed a commit
to openwengo/LibreChat
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add streaming support for o1 models
Issue #4759 : Enhancement: Add streaming support for o1-preview and o1-mini
Summary
This PR adds streaming support for o1 models by removing the if condition that was checking if the model was o1 before deleting the modelOptions.stream and modelOptions.stop parameters in the OpenAIClient.js file.
Change Type
Testing
Backend unit tests are passed:
npm run test:api
Checklist