Skip to content

Commit

Permalink
[MINOR] Silence a warning in MTWrapper
Browse files Browse the repository at this point in the history
* The warning stems from a quick fix that was too quick it seems :-P More specifically, the warning was about using signed and unsigned integers together in the comparison of the for loop condition.

* One more minor thing: cleaned up one debug print in that file
  • Loading branch information
corepointer committed Jul 5, 2023
1 parent 2f0dd55 commit 14ef695
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions src/runtime/local/vectorized/MTWrapper.h
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ class MTWrapperBase {
#else
spdlog::debug("Querying arm cpu topology");
_numCPPThreads = std::thread::hardware_concurrency();
for (auto i = 0; i < _numCPPThreads; i++) {
for (auto i = 0; i < static_cast<int>(_numCPPThreads); i++) {
topologyPhysicalIds.push_back(i);
topologyUniqueThreads.push_back(i);
topologyResponsibleThreads.push_back(i);
Expand Down Expand Up @@ -251,13 +251,8 @@ class MTWrapperBase {
std::cout << std::endl << "_totalNumaDomains=" << _totalNumaDomains << std::endl;
std::cout << "_numQueues=" << _numQueues << std::endl;
}
#ifndef NDEBUG
std::stringstream ss;
ss << "spawning " << this->_numCPPThreads << " CPU and " << this->_numCUDAThreads << " CUDA worker threads"
<< std::endl;
spdlog::debug(ss.str());
// std::cerr << ss.str();
#endif

spdlog::debug("spawning {} CPU and {} CUDA worker threads", this->_numCPPThreads, this->_numCUDAThreads);
}

virtual ~MTWrapperBase() = default;
Expand Down

0 comments on commit 14ef695

Please sign in to comment.