[BUGFIX] Inner join running out of memory #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rootcouse: Due to an intensive call of get() function on frames the program was running out of memory for values bigger than 10^6 (number of rows of the final result). Solution: Decouple the logic in order to only call the get() funcion only once for the insersaction and once for each colum while composing the result. Extra: Creation of a hit vector (intersection) that is used while constructing the result, in order to take advantage of the temporal locality.
corepointer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause: Due to an intensive call of get() function on frames the program was running out of memory for values bigger than 10^6 (number of rows of the final result).
Solution: Decouple the logic in order to only call the get() function only once for the intersection and once for each column while composing the result.