Skip to content
This repository has been archived by the owner on Jun 10, 2022. It is now read-only.

Compatibility with lwIP and ESP-IDF #13

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Compatibility with lwIP and ESP-IDF #13

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8fb16eb
Compatibility with lwIP and ESP-IDF
snej Jun 25, 2018
b431d10
Fixed a logic error due to missing parens
snej Jul 2, 2018
e109fca
Xcode project: define DEBUG=1, not just DEBUG
snej Jul 6, 2018
10d16d6
Xcode: Lower MACOSX_DEPLOYMENT_TARGET to 10.10
snej Aug 21, 2018
d4f5bb7
Added some missing cases to xxx_to_cstr fns
snej Sep 12, 2018
da3f2f9
Added nyoci_outbound_get_packet[_length]()
snej Sep 12, 2018
380864c
Fixed a compiler warning in nyocictl
snej Sep 13, 2018
37319a5
nyocictl: Added env var info to usage/help output
snej Sep 13, 2018
87451c0
Updated CoAP constants in coap.h
snej Sep 14, 2018
c5526dd
Merge branch 'master' into feature/lwIP
snej Sep 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libnyoci/nyoci-outbound.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ nyoci_outbound_add_options_up_to_key_(

#if NYOCI_CONF_TRANS_ENABLE_OBSERVING
if ( (self->current_transaction != NULL)
&& (self->current_transaction->flags & NYOCI_TRANSACTION_OBSERVE == NYOCI_TRANSACTION_OBSERVE)
&& ((self->current_transaction->flags & NYOCI_TRANSACTION_OBSERVE) == NYOCI_TRANSACTION_OBSERVE)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Mind pulling this commit out into it's own pull request?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't claim credit -- GCC found it and warned me (but I can't remember which warning flag it was.)
I'll submit a separate PR when I have a chance.

&& (self->outbound.last_option_key < COAP_OPTION_OBSERVE)
&& (key > COAP_OPTION_OBSERVE)
) {
Expand Down