revert #147 for atalv/azlogr#35

NEWS.md

@@ -11,7 +11,6 @@ Many unrelated small features, fixes and documentation updates collected over 2+
 * new formatter function: `formatter_glue_safe` (#126, @terashim)
 * support `OFF` log level (#138, @pawelru)
 * override default `INFO` log level via env var (#145, requested by sellorm)
-* warn when `formatter_glue` returns nothing (#147, reported by @r2evans)
 
 ## Fixes
 

R/formatters.R

@@ -45,10 +45,11 @@ formatter_glue <- structure(function(..., .logcall = sys.call(), .topcall = sys.
             }))
     ## throw warning with logger inputs on empty response
     if (length(message) == 0) {
-        try(warning(paste(
-            "glue in formatter_glue returned nothing with the following parameters:",
-            paste(..., sep = ' | ')
-        )), silent = TRUE)
+        ## disabled until azlogr drops test for no warning here: https://github.com/atalv/azlogr/issues/35
+        ## try(warning(paste(
+        ##     'glue in formatter_glue returned nothing with the following parameters:',
+        ##     paste(..., sep = ' | ')
+        ## )), silent = TRUE)
     }
     message
 }, generator = quote(formatter_glue()))

tests/testthat/test-formatters.R

@@ -40,9 +40,10 @@ test_that('glue works', {
     expect_error(formatter_glue('malformed {'))
     expect_error(formatter_glue('malformed {{'), NA)
 
-    expect_warning(formatter_glue(NULL))
-    expect_warning(log_info(NULL))
-    expect_warning(log_info(a = 42, b = "foobar"))
+    ## disabled for https://github.com/atalv/azlogr/issues/35
+    ## expect_warning(formatter_glue(NULL))
+    ## expect_warning(log_info(NULL))
+    ## expect_warning(log_info(a = 42, b = "foobar"))
     log_appender(appender_stdout)
 
 })