Check inputs for log_ setters
#170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
added a commit
to hadley/logger
that referenced
this pull request
Aug 6, 2024
Previously created a function then immediately called it. Now it just inlines the results of that function, which leads to a bunch of simplification. Waiting for daroczig#170 since otherwise `catch_base_log()` ends up setting `appender()` to something other than a function. After this can probably deprecate `logger()` since I don't think there's much use for it outside the package anyway.
hadley
changed the title
log_ setterslog_ setters
|
@daroczig this is now ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My most common mistake with logger is accidentally calling
log_formatter(formatter_glue()). This PR causes incorrect usage to generate a clear error. That revealed a few places internally where logger wasn't using a function, which required a minor tweak to the interface oflog_formatter()and friends in order to make them easily reversible.