Use mirai for Async Appender #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works for me interactively, but the tests fail, so if this is of interest, I'll have to explore further.
|
What... |
|
I've fixed in shikokuchuo/mirai@f68afca. If you can come back in a day's time, I'll add a commit that modifies the min version req. for mirai once I've released it. |
|
Thank you so much!! 🙌 |
|
Should be all set now. |
|
Increasing the sleep time just a little makes the coverage test pass for me locally. |
|
oh, thanks a ton, I was not able to repro the error locally |
|
hmmm let me widen it to 1s |
|
fantastic, thanks a ton for this update and all the related small fixes 🙇 |
|
Thanks to @hadley who figured it out. I just tidied up his PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for pointing me to this @daroczig!
Rebases and adds a commit to @hadley's #208 with more efficiency in the setup.
It also maps the logger namespace to mirai's 'compute profile', basically the same concept.
This checks fine for me. The snapshot test error seems unrelated (I'm also getting this locally running off main).
One thing to note is that the background process isn't terminated. This is not a problem in real life as it will automatically terminate when the main session ends, but you should be aware if attempting to test on CRAN for instance. You'd need to add a
daemons(0L, .compute = namespace)somewhere in the teardown.