Fixes for expansion of 'prefer_final_in_for_each' (#1099)

dart-archive · Jun 27, 2023 · 819b959 · 819b959
1 parent 92f2f89
commit 819b959
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/lib/src/common_server_impl.dart b/lib/src/common_server_impl.dart
@@ -254,7 +254,7 @@ class CommonServerImpl {
   Future<proto.VersionResponse> version(proto.VersionRequest _) {
     final packageVersions = getPackageVersions();
     final packageInfos = [
-      for (var packageName in packageVersions.keys)
+      for (final packageName in packageVersions.keys)
         proto.PackageInfo()
           ..name = packageName
           ..version = packageVersions[packageName]!

diff --git a/lib/src/compiler.dart b/lib/src/compiler.dart
@@ -67,7 +67,7 @@ class Compiler {
         sourcesFileList: files.keys.toList(), devMode: _sdk.devMode);
     if (unsupportedImports.isNotEmpty) {
       return CompilationResults(problems: [
-        for (var import in unsupportedImports)
+        for (final import in unsupportedImports)
           CompilationProblem._('unsupported import: ${import.uri.stringValue}'),
       ]);
     }
@@ -155,7 +155,7 @@ class Compiler {
         sourcesFileList: files.keys.toList(), devMode: _sdk.devMode);
     if (unsupportedImports.isNotEmpty) {
       return DDCCompilationResults.failed([
-        for (var import in unsupportedImports)
+        for (final import in unsupportedImports)
           CompilationProblem._('unsupported import: ${import.uri.stringValue}'),
       ]);
     }

diff --git a/lib/src/project_creator.dart b/lib/src/project_creator.dart
@@ -180,7 +180,7 @@ ${_sdk.experiments.map((experiment) => '    - $experiment').join('\n')}
     final allVersions =
         parsePubDependenciesFile(dependenciesFile: _dependenciesFile);
     final result = {
-      for (var package in packages) package: allVersions[package] ?? 'any',
+      for (final package in packages) package: allVersions[package] ?? 'any',
     };
 
     // Overwrite with important constraints.

diff --git a/tool/grind.dart b/tool/grind.dart
@@ -415,10 +415,10 @@ Future<void> _updateDependenciesFile({
   final dependencies = <String, String>{
     'lints': 'any',
     'flutter_lints': 'any',
-    for (var package in firebasePackages) package: 'any',
-    for (var package in supportedFlutterPackages(devMode: sdk.devMode))
+    for (final package in firebasePackages) package: 'any',
+    for (final package in supportedFlutterPackages(devMode: sdk.devMode))
       package: 'any',
-    for (var package in supportedBasicDartPackages(devMode: sdk.devMode))
+    for (final package in supportedBasicDartPackages(devMode: sdk.devMode))
       package: 'any',
   };