Daco's comments

dart-archive · Aug 30, 2023 · dfc4bbb · dfc4bbb
1 parent 2ffce3e
commit dfc4bbb
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/test-package.yml b/.github/workflows/test-package.yml
@@ -19,6 +19,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
+        # TODO: Change to 3.2.0 stable once it's released.
         sdk: [3.2.0-114.0.dev]
     steps:
       - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 - Add support for ObjC Blocks that can be invoked from any thread, using
   NativeCallable.listener.
-- Bump min SDK version to 3.2.
+- Bump min SDK version to 3.2.0-114.0.dev.
 
 # 9.0.1
 

diff --git a/lib/src/code_generator/objc_block.dart b/lib/src/code_generator/objc_block.dart
@@ -143,6 +143,9 @@ class $name extends _ObjCBlockBase {
   /// capabilities and limitations. This block can be invoked from any thread,
   /// but only supports void functions, and is not run synchronously. See
   /// NativeCallable.listener for more details.
+  ///
+  /// Note that unlike the default behavior of NativeCallable.listener, listener
+  /// blocks do not keep the isolate alive.
   $name.listener(${w.className} lib, ${funcType.getDartType(w)} fn) :
       this._(lib.${builtInFunctions.newBlock.name}(
           (_dartFuncListenerTrampoline ??= $nativeCallableType.listener($closureTrampoline

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -4,7 +4,9 @@
 
 name: ffigen
 version: 10.0.0-dev.0
-description: Generator for FFI bindings, using LibClang to parse C header files.
+description: >
+  Generator for FFI bindings, using LibClang to parse C, Objective-C, and Swift
+  files.
 repository: https://github.com/dart-lang/ffigen
 
 topics: