This repository has been archived by the owner on Jan 28, 2024. It is now read-only.
Fix null inference weirdness #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dcharkes
approved these changes
Aug 31, 2023
| @@ -591,7 +591,7 @@ class StringConfigSpec<RE extends Object?> extends ConfigSpec<String, RE> { | |||
| if (!o.checkType<String>(log: log)) { | |||
| return false; | |||
| } | |||
| if (_regexp != null && !_regexp.hasMatch(o.value as String)) { | |||
| if (!(_regexp?.hasMatch(o.value as String) ?? true)) { | |||
There was a problem hiding this comment.
nit: does the ! bind stronger than the ??, I guess it does. Maybe add parenthesis.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to lib/src/config_provider/config_spec.dart in #601 only works on the very latest SDK snapshot. This will make it hard for people to contribute until it hits stable. Better to just rewrite the line to sidestep the inference.