This repository has been archived by the owner on Jan 28, 2024. It is now read-only.
Use correct exceptional return in float blocks #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcharkes
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
lgtm!
Thanks @liamappelbe .
Should we have a bug-fix entry in the CHANGELOG.md?
Also, should we have fixes on the stable branch? 9.0.2 ?
I have a lot of small bug fixes like this in the works. Maybe we can cherry pick them into a stable branch once they're done, if 3.2 isn't stable by then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were generating
0as the exceptional return for float blocks, but we should be generating0.0. Fixes dart-lang/native#452