This repository has been archived by the owner on Jan 28, 2024. It is now read-only.
Better typedefs for NativeFunctions
#621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcharkes
reviewed
Sep 15, 2023
dcharkes
reviewed
Sep 15, 2023
| @@ -10432,6 +10434,11 @@ typedef CXInclusionVisitor = ffi.Pointer< | |||
| ffi.Pointer<CXSourceLocation> inclusion_stack, | |||
| ffi.UnsignedInt include_len, | |||
| CXClientData client_data)>>; | |||
| typedef CXInclusionVisitor_function = ffi.Void Function( | |||
There was a problem hiding this comment.
Naming-wise, it feels like this one should be without _function and the other one should be renamed _pointer. Do you know if we have a lot of uses of these typedefs, if it would be worth the breaking change?
There was a problem hiding this comment.
Not sure, but we could avoid a breaking change by putting this behind a flag. Eg, add a flag called use-function-typedefs, and if it's true we add _pointer to the existing definition and then define the function definition with the current name. WDYT?
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating typedefs for
Pointer<NativeFunction<Function>>, also generate a typedef for theFunction.Fixes dart-lang/native#431.