This repository has been archived by the owner on Jan 28, 2024. It is now read-only.
ObjC static functions #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcharkes
approved these changes
Nov 1, 2023
|
|
||
| @end | ||
|
|
||
| StaticFuncTestObj* staticFuncOfObject(StaticFuncTestObj* a) { |
There was a problem hiding this comment.
Can we move these (the actual functions used in the test) up, and the helper object down? Or does ObjC require an ordering?
There was a problem hiding this comment.
Done. Just need to have the interface decl above them I think.
| calloc.free(gcNow); | ||
| } | ||
|
|
||
| Pointer<Int32> staticFuncOfObjectRefCountTest(Allocator alloc) { |
There was a problem hiding this comment.
It seems this only has one call site, is this because of scoping that it's in a separate function?
There was a problem hiding this comment.
Yep. I use the function scoping and doGC() to ensure that all the wrapper objects are collected.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Dart wrapper objects when passing args or receiving results from ObjC static functions.
For ref counting, we assume functions do not return a retained reference by default (so we have to retain it ourselves). We also parse the function annotations, and if we see a
NS_RETURNS_RETAINED, then the function is returning a retained reference, so we don't have to manually retain it in that case.Fixes dart-lang/native#496, dart-lang/native#308