This repository has been archived by the owner on Sep 28, 2024. It is now read-only.
Support retrying Datastore operations. #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
reviewed
Jul 20, 2023
lib/datastore.dart
Outdated
| /// operation. | ||
| factory Datastore.withRetry( | ||
| Datastore delegate, { | ||
| RetryOptions? retryOptions, |
There was a problem hiding this comment.
Let's not make types from package:retry public. I think maxAttempts and maybe retryIf is the maximum arguments we need to expose.
Also if we ever need we can remove the dependency on package:retry.
There was a problem hiding this comment.
Leaving retryIf for a later extension of the API, we may not need it after all...
lib/src/retry_datastore_impl.dart
Outdated
| } | ||
| } | ||
|
|
||
| bool _retryIf(Exception e) => e is! datastore.TransactionAbortedError; |
There was a problem hiding this comment.
- NeedIndexError
- PermissionDeniedError
- QuotaExceededError
might not be worth retrying?
side note: The only one I see any code throw is NeedIndexError... So there is something else we could improve 🙈
jonasfj
approved these changes
Jul 21, 2023
devoncarew
pushed a commit
to dart-lang/labs
that referenced
this pull request
Sep 27, 2024
* Support retrying Datastore operations. * Expose only maxAttempts * add more errors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.