This repository has been archived by the owner on Sep 28, 2024. It is now read-only.
Fix missing retries in Page.next #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
approved these changes
Aug 10, 2023
|
For deprecation message see: |
sigurdm
reviewed
Aug 10, 2023
| @@ -428,7 +429,10 @@ class _SubscriptionImpl implements Subscription { | |||
| Future delete() => _api._deleteSubscription(_subscription.name!); | |||
|
|
|||
| @override | |||
| Future<PullEvent?> pull({bool wait = true}) { | |||
| Future<PullEvent?> pull({ | |||
| @Deprecated('returnImmediately has been deprecated from pubsub') | |||
There was a problem hiding this comment.
Perhaps leave a link to the documentation...
There was a problem hiding this comment.
there isn't really any.
There was a problem hiding this comment.
Well you could have linked to: https://cloud.google.com/pubsub/docs/reference/rest/v1/projects.subscriptions/pull
sigurdm
approved these changes
Aug 10, 2023
devoncarew
pushed a commit
to dart-lang/labs
that referenced
this pull request
Sep 27, 2024
* Fix missing retries in Page.next * Ignore deprecated usage * Propogate deprecation message
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @isoos