Skip to content
This repository has been archived by the owner on Sep 28, 2024. It is now read-only.

Spelling #189

Merged
merged 13 commits into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,9 @@

* Remove support for `FilterRelation.In` and "propertyname IN" for queries:
This is not supported by the newer APIs and was originally part of fat-client
libraries which performed multiple queries for each iten in the list.
libraries which performed multiple queries for each item in the list.

* Adds optional `forComparision` named argument to `Property.encodeValue` which
* Adds optional `forComparison` named argument to `Property.encodeValue` which
will be set to `true` when encoding a value for comparison in queries.

* Upgrade to newer versions of `package:googleapis` and `package:googleapis_beta`
Expand Down Expand Up @@ -232,7 +232,7 @@

## 0.1.3+1

* Change the service scope keys keys to non-private symbols.
* Change the service scope keys to non-private symbols.

## 0.1.3

Expand Down
8 changes: 4 additions & 4 deletions lib/datastore.dart
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,14 @@ class DatastoreError implements Exception {
final String message;

DatastoreError([String? message])
: message = message ?? 'DatastoreError: An unknown error occured';
: message = message ?? 'DatastoreError: An unknown error occurred';

@override
String toString() => message;
}

class UnknownDatastoreError extends DatastoreError {
UnknownDatastoreError(error) : super('An unknown error occured ($error).');
UnknownDatastoreError(error) : super('An unknown error occurred ($error).');
}

class TransactionAbortedError extends DatastoreError {
Expand Down Expand Up @@ -123,7 +123,7 @@ class Entity {
/// A key can uniquely identify a datastore `Entity`s. It consists of a
/// partition and path. The path consists of one or more `KeyElement`s.
///
/// A key may be incomplete. This is usesful when inserting `Entity`s which IDs
/// A key may be incomplete. This is useful when inserting `Entity`s which IDs
/// should be automatically allocated.
///
/// Example of a fully populated [Key]:
Expand Down Expand Up @@ -386,7 +386,7 @@ abstract class Datastore {
///
/// The [project] is the name of the Google Cloud project.
///
/// Returs an object providing access to Datastore. The passed-in [client]
/// Returns an object providing access to Datastore. The passed-in [client]
/// will not be closed automatically. The caller is responsible for closing
/// it.
factory Datastore(http.Client client, String project) {
Expand Down
4 changes: 2 additions & 2 deletions lib/pubsub.dart
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ PubSub get pubsubService => ss.lookup(_pubsubKey) as PubSub;

/// Registers the [pubsub] object within the current service scope.
///
/// The provided `pubsub` object will be avilable via the top-level
/// The provided `pubsub` object will be available via the top-level
/// `pubsubService` getter.
///
/// Calling this function outside of a service scope will result in an error.
Expand Down Expand Up @@ -121,7 +121,7 @@ abstract class PubSub {
///
/// The [project] is the name of the Google Cloud project.
///
/// Returs an object providing access to Pub/Sub. The passed-in [client] will
/// Returns an object providing access to Pub/Sub. The passed-in [client] will
/// not be closed automatically. The caller is responsible for closing it.
factory PubSub(http.Client client, String project) {
var emulator = Platform.environment['PUBSUB_EMULATOR_HOST'];
Expand Down
2 changes: 1 addition & 1 deletion lib/service_scope.dart
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ class _ServiceScope {
_destroyed = true;
if (errors.isNotEmpty) {
throw Exception(
'The following errors occured while running scope exit handlers'
'The following errors occurred while running scope exit handlers'
': $errors');
}
});
Expand Down
2 changes: 1 addition & 1 deletion lib/src/datastore_impl.dart
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ class DatastoreImpl implements datastore.Datastore {
if (error.status == 400) {
return Future.error(
datastore.ApplicationError(
error.message ?? 'An unknown error occured',
error.message ?? 'An unknown error occurred',
),
stack,
);
Expand Down
2 changes: 1 addition & 1 deletion lib/src/db/db.dart
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ Future _commitHelper(DatastoreDB db,

for (var model in inserts) {
// If parent was not explicitly set, we assume this model will map to
// it's own entity group.
// its own entity group.
model.parentKey ??= db.defaultPartition.emptyKey;
if (model.id == null) {
autoIdModelInserts.add(model);
Expand Down
4 changes: 2 additions & 2 deletions lib/storage.dart
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
/// In most cases relative names are used. Absolute names are typically
/// only used for operations involving objects in different buckets.
///
/// For most of the APIs in ths library which take instances of other classes
/// For most of the APIs in this library which take instances of other classes
/// from this library it is the assumption that the actual implementations
/// provided here are used.
library;
Expand Down Expand Up @@ -260,7 +260,7 @@ abstract class AclScope {
/// are set in the different subclasses.
final String _id;

/// The type of this acope this ACL scope represents.
/// The type of this scope this ACL scope represents.
final int _type;

/// ACL scope for all authenticated users.
Expand Down
2 changes: 1 addition & 1 deletion test/datastore/e2e/datastore_test_impl.dart
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ void runTests(Datastore datastore, String? namespace) {
});
});

// This should not work with [unamedEntities20], but is working!
// This should not work with [unnamedEntities20], but is working!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be wrong...

// FIXME TODO FIXME : look into this.
test('delete_transactional', () {
return insert([], unnamedEntities99, transactional: false).then((keys) {
Expand Down
4 changes: 2 additions & 2 deletions test/service_scope_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ void main() {
}));
});

test('non-existent-key', () {
test('nonexistent-key', () {
return ss.fork(expectAsync0(() {
expect(ss.lookup(1), isNull);
return Future.value();
Expand Down Expand Up @@ -188,7 +188,7 @@ void main() {
});

test('nested-fork-and-insert', () {
// Ensure that independently fork()ed serice scopes can insert keys
// Ensure that independently fork()ed service scopes can insert keys
// independently and they cannot see each others values but can see parent
// service scope values.
var rootKey = 1;
Expand Down