Spelling api #193
Spelling api #193
Conversation
jsoref
force-pushed
the
spelling-api
branch
from
cd4f043
to
0c8ca9e
Compare
There was a problem hiding this comment.
This is how APIs should be migrated.
GreatherThan is really poorly spelled 🤣, but it could happen to the best of us (and does -- repeatedly 🙈).
But it would also be sad, if we had to a disruptive major version bump, just to fix a typo.
This way we get a rename, without breaking anything, and as a cherry on top we get automated fixes!
lib/datastore.dart
Outdated
| /// Old misspelled name for [GreaterThan], retained for compatibility. | ||
| /// | ||
| /// @nodoc | ||
| @Deprecated('Use FilterRelation.GreaterThan instead') | ||
| static const FilterRelation GreatherThan = FilterRelation._('>'); |
There was a problem hiding this comment.
| static const FilterRelation GreatherThan = FilterRelation._('>'); | |
| static const FilterRelation GreatherThan = GreaterThan; |
We want identity equality to be preserved, we want GreatherThan == GreaterThan.
The _relationMapping stuff in lib/src/db/db.dart won't work.
There was a problem hiding this comment.
Can you clarify won't work?
There was a problem hiding this comment.
Sorry, I got it wrong, it was relationMapping in lib/src/datastore_impl.dart:
Would cause problems in:
https://github.com/dart-lang/gcloud/blob/eee174cdbfaeaef0c977f0b38e26c2d0a85ce4b5/lib/src/datastore_impl.dart#L214-L217
Unless, GreatherThan and GreaterThan are the same object. In practice, I guess it also creates one object less to use the same object, but that's more like a nit 🤣
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref
force-pushed
the
spelling-api
branch
from
0c8ca9e
to
b271253
Compare
* spelling: descending [api] Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: greater [api] Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --------- Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Per @jonasfj in #189 (comment)