Add correct cast to interface method invocation (#385)

dart-archive · Sep 10, 2023 · 49d4ac0 · 49d4ac0
1 parent b845ff1
commit 49d4ac0
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 6 deletions.
diff --git a/jnigen/CHANGELOG.md b/jnigen/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 0.6.1-wip
+* Added an explicit cast in generated `<Interface>.implement` code to allow `dart analyze` to pass when `strict-casts` is set.
+
 ## 0.6.0
 * **Breaking Change** ([#131](https://github.com/dart-lang/jnigen/issues/131)): Renamed `delete*` to `release*`.
 * **Breaking Change** ([#354](https://github.com/dart-lang/jnigen/issues/354)): Renamed constructors from `ctor1`, `ctor2`, ... to `new1`, `new2`, ...

diff --git a/jnigen/lib/src/bindings/dart_generator.dart b/jnigen/lib/src/bindings/dart_generator.dart
@@ -479,7 +479,7 @@ class $name$typeParamsDef extends $superName {
         \$p.close();
         return;
       }
-      final \$i = \$MethodInvocation.fromMessage(\$m);
+      final \$i = \$MethodInvocation.fromMessage(\$m as List<dynamic>);
       final \$r = _\$invokeMethod(\$p.sendPort.nativePort, \$i);
       $_protectedExtension.returnResult(\$i.result, \$r);
     });

diff --git a/jnigen/pubspec.yaml b/jnigen/pubspec.yaml
@@ -4,7 +4,7 @@
 
 name: jnigen
 description: A Dart bindings generator for Java and Kotlin that uses JNI under the hood to interop with Java virtual machine.
-version: 0.6.0
+version: 0.6.1-wip
 repository: https://github.com/dart-lang/jnigen/tree/main/jnigen
 
 environment:

diff --git a/jnigen/test/simple_package_test/c_based/dart_bindings/simple_package.dart b/jnigen/test/simple_package_test/c_based/dart_bindings/simple_package.dart
@@ -3435,7 +3435,7 @@ class MyInterface<$T extends jni.JObject> extends jni.JObject {
         $p.close();
         return;
       }
-      final $i = $MethodInvocation.fromMessage($m);
+      final $i = $MethodInvocation.fromMessage($m as List<dynamic>);
       final $r = _$invokeMethod($p.sendPort.nativePort, $i);
       ProtectedJniExtensions.returnResult($i.result, $r);
     });
@@ -3733,7 +3733,7 @@ class MyRunnable extends jni.JObject {
         $p.close();
         return;
       }
-      final $i = $MethodInvocation.fromMessage($m);
+      final $i = $MethodInvocation.fromMessage($m as List<dynamic>);
       final $r = _$invokeMethod($p.sendPort.nativePort, $i);
       ProtectedJniExtensions.returnResult($i.result, $r);
     });

diff --git a/jnigen/test/simple_package_test/dart_only/dart_bindings/simple_package.dart b/jnigen/test/simple_package_test/dart_only/dart_bindings/simple_package.dart
@@ -3244,7 +3244,7 @@ class MyInterface<$T extends jni.JObject> extends jni.JObject {
         $p.close();
         return;
       }
-      final $i = $MethodInvocation.fromMessage($m);
+      final $i = $MethodInvocation.fromMessage($m as List<dynamic>);
       final $r = _$invokeMethod($p.sendPort.nativePort, $i);
       ProtectedJniExtensions.returnResult($i.result, $r);
     });
@@ -3540,7 +3540,7 @@ class MyRunnable extends jni.JObject {
         $p.close();
         return;
       }
-      final $i = $MethodInvocation.fromMessage($m);
+      final $i = $MethodInvocation.fromMessage($m as List<dynamic>);
       final $r = _$invokeMethod($p.sendPort.nativePort, $i);
       ProtectedJniExtensions.returnResult($i.result, $r);
     });