Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

WIP: Use super.reference in fromRef constructors #399

Closed
wants to merge 1 commit into from
Closed

WIP: Use super.reference in fromRef constructors #399

wants to merge 1 commit into from

Conversation

HosseinYousefi
Copy link
Contributor

@HosseinYousefi HosseinYousefi commented Sep 20, 2023 •
edited
Loading

Minor refactoring to use the newer Dart features in both the generated code and in package:jni classes.

WIP: There is still some issues with subclasses in the generated code.

@HosseinYousefi HosseinYousefi marked this pull request as draft September 20, 2023 12:25
@HosseinYousefi HosseinYousefi changed the title Use super.reference in fromRef constructors WIP: Use super.reference in fromRef constructors Sep 20, 2023
@HosseinYousefi HosseinYousefi removed the request for review from dcharkes September 20, 2023 12:30
@HosseinYousefi
Copy link
Contributor Author

Closing this as using super.reference would required fromRef to accept required named parameters for the type classes (similar to other constructors and methods). However this is a larger change than what I originally intended and it will not benefit the user since fromRef is rarely used directly.

@HosseinYousefi HosseinYousefi deleted the use-super branch September 20, 2023 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HosseinYousefi