This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
Renamed types that have the same name as a variable, but aren't directly related #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Nov 19, 2019
jacob314
reviewed
Nov 19, 2019
whether types with names that conflict with variable names get renamed or get merged with the variable. Added --rename-conflicting-types flag Made variables with the same name as types get merged into the types by default Separated handling of type names and value names in FacadeConverter
derekxu16
commented
Nov 22, 2019
Comment on lines
-1092
to
-1094
| declare type Y = X; | ||
|
|
||
| declare var Y: Y; |
There was a problem hiding this comment.
This alias doesn't work anymore since generateDartTypeName detects that Y is declared as an alias, so it ends up skipping the emission of class Y. This has been documented in #68.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.