migrate template defaults to use package:pedantic for lints (#594)

Closes #593.
dart-archive · Jan 22, 2019 · dad2cde · dad2cde
1 parent 96dc51e
commit dad2cde
Show file tree

Hide file tree

Showing 20 changed files with 148 additions and 136 deletions.
diff --git a/lib/src/generators/console_full.g.dart b/lib/src/generators/console_full.g.dart
diff --git a/lib/src/generators/package_simple.g.dart b/lib/src/generators/package_simple.g.dart
diff --git a/lib/src/generators/server_shelf.g.dart b/lib/src/generators/server_shelf.g.dart
diff --git a/lib/src/generators/web_angular.g.dart b/lib/src/generators/web_angular.g.dart
diff --git a/lib/src/generators/web_simple.g.dart b/lib/src/generators/web_simple.g.dart
diff --git a/lib/src/generators/web_stagexl.g.dart b/lib/src/generators/web_stagexl.g.dart
diff --git a/templates/analysis_options.yaml b/templates/analysis_options.yaml
@@ -1,14 +1,14 @@
+# Defines a default set of lint rules enforced for
+# projects at Google. For details and rationale,
+# see https://github.com/dart-lang/pedantic#enabled-lints.
+include: package:pedantic/analysis_options.yaml
+
+# For lint rules and documentation, see http://dart-lang.github.io/linter/lints.
+# Uncomment to specify additional rules.
+# linter:
+#   rules:
+#     - camel_case_types
+
 analyzer:
 #   exclude:
 #     - path/to/excluded/files/**
-
-# Lint rules and documentation, see http://dart-lang.github.io/linter/lints
-linter:
-  rules:
-    - cancel_subscriptions
-    - hash_and_equals
-    - iterable_contains_unrelated_type
-    - list_remove_unrelated_type
-    - test_types_in_equals
-    - unrelated_type_equality_checks
-    - valid_regexps
diff --git a/templates/console-full/analysis_options.yaml b/templates/console-full/analysis_options.yaml
@@ -1,14 +1,14 @@
+# Defines a default set of lint rules enforced for
+# projects at Google. For details and rationale,
+# see https://github.com/dart-lang/pedantic#enabled-lints.
+include: package:pedantic/analysis_options.yaml
+
+# For lint rules and documentation, see http://dart-lang.github.io/linter/lints.
+# Uncomment to specify additional rules.
+# linter:
+#   rules:
+#     - camel_case_types
+
 analyzer:
 #   exclude:
 #     - path/to/excluded/files/**
-
-# Lint rules and documentation, see http://dart-lang.github.io/linter/lints
-linter:
-  rules:
-    - cancel_subscriptions
-    - hash_and_equals
-    - iterable_contains_unrelated_type
-    - list_remove_unrelated_type
-    - test_types_in_equals
-    - unrelated_type_equality_checks
-    - valid_regexps
diff --git a/templates/console-full/pubspec.yaml b/templates/console-full/pubspec.yaml
@@ -11,4 +11,5 @@ environment:
 #  path: ^1.4.1
 
 dev_dependencies:
+  pedantic: ^1.0.0
   test: ^1.0.0
diff --git a/templates/package-simple/analysis_options.yaml b/templates/package-simple/analysis_options.yaml
@@ -1,14 +1,14 @@
+# Defines a default set of lint rules enforced for
+# projects at Google. For details and rationale,
+# see https://github.com/dart-lang/pedantic#enabled-lints.
+include: package:pedantic/analysis_options.yaml
+
+# For lint rules and documentation, see http://dart-lang.github.io/linter/lints.
+# Uncomment to specify additional rules.
+# linter:
+#   rules:
+#     - camel_case_types
+
 analyzer:
 #   exclude:
 #     - path/to/excluded/files/**
-
-# Lint rules and documentation, see http://dart-lang.github.io/linter/lints
-linter:
-  rules:
-    - cancel_subscriptions
-    - hash_and_equals
-    - iterable_contains_unrelated_type
-    - list_remove_unrelated_type
-    - test_types_in_equals
-    - unrelated_type_equality_checks
-    - valid_regexps
diff --git a/templates/package-simple/pubspec.yaml b/templates/package-simple/pubspec.yaml
@@ -11,4 +11,5 @@ environment:
 #  path: ^1.4.1
 
 dev_dependencies:
+  pedantic: ^1.0.0
   test: ^1.0.0
diff --git a/templates/server-shelf/analysis_options.yaml b/templates/server-shelf/analysis_options.yaml
@@ -1,14 +1,14 @@
+# Defines a default set of lint rules enforced for
+# projects at Google. For details and rationale,
+# see https://github.com/dart-lang/pedantic#enabled-lints.
+include: package:pedantic/analysis_options.yaml
+
+# For lint rules and documentation, see http://dart-lang.github.io/linter/lints.
+# Uncomment to specify additional rules.
+# linter:
+#   rules:
+#     - camel_case_types
+
 analyzer:
 #   exclude:
 #     - path/to/excluded/files/**
-
-# Lint rules and documentation, see http://dart-lang.github.io/linter/lints
-linter:
-  rules:
-    - cancel_subscriptions
-    - hash_and_equals
-    - iterable_contains_unrelated_type
-    - list_remove_unrelated_type
-    - test_types_in_equals
-    - unrelated_type_equality_checks
-    - valid_regexps
diff --git a/templates/server-shelf/pubspec.yaml b/templates/server-shelf/pubspec.yaml
@@ -11,5 +11,5 @@ dependencies:
   args: ^1.4.2
   shelf: ^0.7.2
 
-#dev_dependencies:
-#  test: ^1.0.0
+dev_dependencies:
+  pedantic: ^1.0.0
diff --git a/templates/web-angular/analysis_options.yaml b/templates/web-angular/analysis_options.yaml
@@ -1,3 +1,14 @@
+# Defines a default set of lint rules enforced for
+# projects at Google. For details and rationale,
+# see https://github.com/dart-lang/pedantic#enabled-lints.
+include: package:pedantic/analysis_options.yaml
+
+# For lint rules and documentation, see http://dart-lang.github.io/linter/lints.
+# Uncomment to specify additional rules.
+# linter:
+#   rules:
+#     - camel_case_types
+
 analyzer:
   exclude: [build/**]
   errors:
@@ -6,14 +17,3 @@ analyzer:
   # issues: https://github.com/dart-lang/angular_analyzer_plugin/issues
   # plugins:
     # - angular
-
-# Lint rules and documentation, see http://dart-lang.github.io/linter/lints
-linter:
-  rules:
-    - cancel_subscriptions
-    - hash_and_equals
-    - iterable_contains_unrelated_type
-    - list_remove_unrelated_type
-    - test_types_in_equals
-    - unrelated_type_equality_checks
-    - valid_regexps
diff --git a/templates/web-angular/pubspec.yaml b/templates/web-angular/pubspec.yaml
@@ -16,4 +16,5 @@ dev_dependencies:
   build_runner: ^1.1.2
   build_test: ^0.10.3
   build_web_compilers: ^1.0.0
+  pedantic: ^1.0.0
   test: ^1.5.1
diff --git a/templates/web-simple/analysis_options.yaml b/templates/web-simple/analysis_options.yaml
@@ -1,14 +1,14 @@
+# Defines a default set of lint rules enforced for
+# projects at Google. For details and rationale,
+# see https://github.com/dart-lang/pedantic#enabled-lints.
+include: package:pedantic/analysis_options.yaml
+
+# For lint rules and documentation, see http://dart-lang.github.io/linter/lints.
+# Uncomment to specify additional rules.
+# linter:
+#   rules:
+#     - camel_case_types
+
 analyzer:
 #   exclude:
 #     - path/to/excluded/files/**
-
-# Lint rules and documentation, see http://dart-lang.github.io/linter/lints
-linter:
-  rules:
-    - cancel_subscriptions
-    - hash_and_equals
-    - iterable_contains_unrelated_type
-    - list_remove_unrelated_type
-    - test_types_in_equals
-    - unrelated_type_equality_checks
-    - valid_regexps
diff --git a/templates/web-simple/pubspec.yaml b/templates/web-simple/pubspec.yaml
@@ -13,3 +13,4 @@ environment:
 dev_dependencies:
   build_runner: ^1.1.2
   build_web_compilers: ^1.0.0
+  pedantic: ^1.0.0