StageXL app generator. #381

Tomucha · 2017-03-18T09:28:51Z

See https://github.com/google/stagehand/issues/377

Result project was approved by @bp74.

kwalrath

Fun template! After a few tweaks, I'll be happy to accept this.

kwalrath · 2017-03-20T16:47:10Z

README.md

@@ -20,6 +20,7 @@ Kit and Yeoman.
 * `web-angular` - A web app built using the latest stable version of Angular.
 * `web-angular-simple` - A minimalist example app used in docs.
 * `web-simple` - An absolute bare-bones web app.
+* `web-stagexl` - A basic 2D canvas app with StageXL


Add a period at the end, to match other items in the list.

Actually... It looks like lib/generators/web_stagexl.dart has this right, so if you run dart tool/grind.dart build this should update to have the right text.

kwalrath · 2017-03-20T16:49:35Z

templates/web-stagexl/web/main.dart

+  logo.pivotX = logoData.width / 2;
+  logo.pivotY = logoData.height / 2;
+
+  // place it on top-center


Per https://www.dartlang.org/guides/language/effective-dart/documentation#do-format-comments-like-sentences, format this like a sentence. (And maybe "on" should be "at"? Also, the hyphen seems unnecessary.)

// Place it at top center.

kwalrath · 2017-03-20T16:51:39Z

templates/web-stagexl/web/main.dart

+
+  stage.addChild(logo);
+
+  // ... and let it fall


Again, please format this like a sentence:

// And let it fall.

kwalrath · 2017-03-20T16:52:04Z

templates/web-stagexl/web/main.dart

+  var tween = stage.juggler.addTween(logo, 3, Transition.easeOutBounce);
+  tween.animate.y.to(800 / 2);
+
+  // see more examples:


kwalrath · 2017-03-20T16:52:51Z

templates/web-stagexl/pubspec.yaml

+  sdk: '>=1.20.1 <2.0.0'
+
+dependencies:
+  stagexl: '^1.1.0'


Remove the 's around this ^ dependency.

kwalrath · 2017-03-20T16:53:22Z

templates/web-stagexl/pubspec.yaml

@@ -0,0 +1,18 @@
+name: __projectName__
+description: An absolute bare-bones web app.


Change to something more specific. Maybe:

description: A simple StageXL web app.

kwalrath · 2017-03-20T16:55:51Z

site/index.html

@@ -92,6 +92,7 @@ <h1 id="usage">Usage</h1>
  <li>web-angular - <em>A web app built using the latest stable version of Angular.</em></li>
  <li>web-angular-simple - <em>A minimalist example app used in docs.</em></li>
  <li>web-simple - <em>An absolute bare-bones web app.</em></li>
+  <li>web-stagexl - <em>A basic 2D canvas app with StageXL</em></li>


Add a period before the final </em>, to match the other items in the list.

kwalrath · 2017-03-20T17:14:59Z

@kevmoo, care to review the code?

https://github.com/google/stagehand/pull/381#pullrequestreview-27899225

kevmoo · 2017-03-20T17:41:59Z

templates/web-stagexl/web/main.dart

+  stage.addChild(logo);
+
+  // And let it fall.
+  var tween = stage.juggler.addTween(logo, 3, Transition.easeOutBounce);


Could we set this up so that it dances on mouse-over...or reanimates when clicked?

Just something so it feel playful and shows a bit of event handling.

kevmoo · 2017-03-20T17:42:18Z

templates/web-stagexl/web/main.dart

+import 'package:stagexl/stagexl.dart';
+
+Future<Null> main() async {
+


Please run dartfmt – I see a few extra lines.

kwalrath

LGTM. @kevmoo?

kwalrath · 2017-03-20T22:41:49Z

templates/web-stagexl/web/main.dart

@@ -2,16 +2,16 @@
 // is governed by a BSD-style license that can be found in the LICENSE file.

 import 'dart:async';
-import 'dart:html';
+import 'dart:html' as html;
 import 'package:stagexl/stagexl.dart';


The imports should be alphabetical, and I think there should be a blank line above the package import.

Yup. Between dart:* and package:* imports.

kevmoo

Awesome!

I'll do the pubspec/changelog cleanup – save you from our nitpicking 😄

Thanks so much!

kevmoo · 2017-03-20T22:49:54Z

templates/web-stagexl/web/styles.css

+    margin: 0;
+    padding: 0;
+    border: 0;
+}


missing newline

Tomucha · 2017-03-21T06:21:39Z

Thanks!

filiph · 2017-03-21T15:52:57Z

Great idea and awesome template, thanks!

Was tool/grind.dart build run on this before submitting? It looks like the commit doesn't include the data files. Or have we stopped putting those files into version control?

Tomucha · 2017-03-21T15:55:52Z

It's all there: https://github.com/google/stagehand/pull/381/files/d268114819cbffb18ae6ac1db440c233efdceb2e#diff-93fce550d136fd7c8560ff122f2a1a1e

But it's collapsed in commit view, maybe you overlooked it ... ?

filiph · 2017-03-21T20:35:49Z

Ah! Yes, I overlooked it. Sorry for the confusion!

kwalrath · 2017-05-05T17:04:48Z

@Tomucha unfortunately we have to reduce the number of templates (#390), so we'll be removing yours. We're also removing the web-angular-simple template, and I thought you might be interested in how we handled that.

https://github.com/dart-lang/site-webdev/pull/596 has the details, but basically we changed our instructions to refer to a GitHub repo. https://webdev.dartlang.org/angular/guide/setup#create-a-starter-project has detailed instructions on getting the project's files, with links to the GitHub download URL plus instructions on using WebStorm to clone a repo.

Tomucha · 2017-05-07T19:47:32Z

Obviously I disagree:

Remove one CLI template and one Angular - they cause the problem
Then run UX tests again. If it doesn't help:
THEN remove web-simple - it's useless jQuery style Hello World anyway

All I'm saying: Don't throw the baby out with the bathwater.

kwalrath · 2017-05-08T21:04:37Z

After talking with @filiph, we've agreed to keep the StageXL template (for now, at least).

But we have to make the description more inviting! I'll file an issue about this.

kwalrath · 2017-05-08T21:30:51Z

Issue filed: #402. And fixed: #403.

Tomucha added 2 commits March 15, 2017 19:48

StageXL app generator.

205c978

Fixed typo.

74e3641

kwalrath self-assigned this Mar 20, 2017

kwalrath reviewed Mar 20, 2017

View reviewed changes

kwalrath requested a review from kevmoo March 20, 2017 17:14

Tuning of text and comments as requested:

1e76267

https://github.com/google/stagehand/pull/381#pullrequestreview-27899225

kevmoo suggested changes Mar 20, 2017

View reviewed changes

Added some interaction as @kevmoo requested.

d268114

kwalrath approved these changes Mar 20, 2017

View reviewed changes

kevmoo approved these changes Mar 20, 2017

View reviewed changes

templates/web-stagexl/web/styles.css

margin: 0;

padding: 0;

border: 0;

}

Copy link

Contributor

kevmoo Mar 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline

kevmoo merged commit 21cb456 into dart-archive:master Mar 21, 2017

kwalrath mentioned this pull request Feb 26, 2020

remove the 'web-stagexl' template #656

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

StageXL app generator. #381

StageXL app generator. #381

Tomucha commented Mar 18, 2017

kwalrath left a comment

kwalrath Mar 20, 2017

kwalrath Mar 20, 2017 •

edited

Loading

kwalrath Mar 20, 2017

kwalrath Mar 20, 2017

kwalrath Mar 20, 2017

kwalrath Mar 20, 2017

kwalrath Mar 20, 2017

kwalrath commented Mar 20, 2017

kevmoo Mar 20, 2017

kevmoo Mar 20, 2017

kwalrath left a comment

kwalrath Mar 20, 2017

kevmoo Mar 20, 2017

kevmoo left a comment

kevmoo Mar 20, 2017

Tomucha commented Mar 21, 2017

filiph commented Mar 21, 2017

Tomucha commented Mar 21, 2017

filiph commented Mar 21, 2017

kwalrath commented May 5, 2017

Tomucha commented May 7, 2017

kwalrath commented May 8, 2017

kwalrath commented May 8, 2017 •

edited

Loading

		@@ -0,0 +1,18 @@
		name: __projectName__
		description: An absolute bare-bones web app.

		import 'package:stagexl/stagexl.dart';

		Future<Null> main() async {

StageXL app generator. #381

StageXL app generator. #381

Conversation

Tomucha commented Mar 18, 2017

kwalrath left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kwalrath Mar 20, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kwalrath commented Mar 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kwalrath left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevmoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tomucha commented Mar 21, 2017

filiph commented Mar 21, 2017

Tomucha commented Mar 21, 2017

filiph commented Mar 21, 2017

kwalrath commented May 5, 2017

Tomucha commented May 7, 2017

kwalrath commented May 8, 2017

kwalrath commented May 8, 2017 • edited Loading

kwalrath Mar 20, 2017 •

edited

Loading

kwalrath commented May 8, 2017 •

edited

Loading