-
Notifications
You must be signed in to change notification settings - Fork 25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you expand on the change here? Why is it done?
Also, does this change the public API?
If so, we need to bump the pubspec version and add a changelog entry
Expanded the description a bit. This change doesn't affect the API at all. |
Is it worth a changelog entry? It changes behavior, right? Should we bump to v0.2.0? |
It doesn't change user facing behavior. Users don't have access to the stores. |
@liamappelbe – then why are folks asking for the change? 😄 This change does SOMETHING. There are reasons folks want the change, right? Can't we put that in the changelog? |
It doesn't do anything by itself, but it will enable me to make some user facing changes that will go in the changelog. If you prefer, I can hold off submitting this until I have some of those changes to go with it. |
Oh! Well...okay then. 😄 |
Ok, from reading that, I think it probably does make sense to add a -dev version to the changelog, and group this change with the features that depend on it into a new minor version. Still getting used to this workflow 🙃 |
You can still land this change – but at least with a version bump and a |
This is one of the feature requests from #38
This change should be transparent to users at this stage, but will enable future features like sharing memory or functions between modules.