Skip to content
This repository has been archived by the owner on Jul 1, 2023. It is now read-only.

Initial commit of package:flutter_wasm #55

Merged
merged 23 commits into from
Oct 29, 2021
Merged

Initial commit of package:flutter_wasm #55

merged 23 commits into from
Oct 29, 2021

Conversation

liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Oct 26, 2021 •
edited
Loading

Only Android is supported at the moment. #40

@liamappelbe
Copy link
Contributor Author

@kevmoo How should I set up the github workflows for this pluggin?

@kevmoo
Copy link
Contributor

kevmoo commented Oct 26, 2021

@liamappelbe – you'll have to set up your own workflow for Flutter.

Maybe start at https://github.com/marketplace/actions/flutter-action ?

kevmoo
kevmoo reviewed Oct 27, 2021
View reviewed changes
flutter_wasm/pubspec.yaml Outdated Show resolved Hide resolved
@liamappelbe
Copy link
Contributor Author

I don't really understand the git@github.com: Permission denied (publickey). error. Is this because flutter_wasm is currently depending on wasm using a git dependency?

@kevmoo
Copy link
Contributor

kevmoo commented Oct 27, 2021

I don't really understand the git@github.com: Permission denied (publickey). error. Is this because flutter_wasm is currently depending on wasm using a git dependency?

LIkely. Try using an https: dep instead of git@

@liamappelbe
Copy link
Contributor Author

I can't repro the analysis failures locally. Why would it not be able to find package:flutter_wasm_example/main.dart?

kevmoo
kevmoo reviewed Oct 28, 2021
View reviewed changes
.github/workflows/test-package.yml
run: flutter pub upgrade
run: |
flutter pub upgrade
flutter pub upgrade --directory example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liamappelbe – now analyze is working – need to run upgrade in both dirs!

@kevmoo
Copy link
Contributor

kevmoo commented Oct 28, 2021

Getting close!

@liamappelbe
Copy link
Contributor Author

wooo!!!

@liamappelbe liamappelbe merged commit fd25783 into main Oct 29, 2021
@liamappelbe liamappelbe deleted the flutter3 branch October 29, 2021 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevmoo kevmoo kevmoo left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamappelbe @kevmoo