This repository has been archived by the owner on Jul 1, 2023. It is now read-only.
Async compilation and instantiation #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lexaknyazev are there any other functions that need async equivalents? |
|
The web platform has these async entry points (all exposed by the
|
|
Going directly from bytes to an instance doesn't fit nicely with the way we're doing imports, so I'll leave that out for now. |
kevmoo
reviewed
Nov 10, 2021
| @@ -21,6 +21,10 @@ class WasmModule { | |||
| /// Deserialize a module. See [WasmModule.serialize] for more details. | |||
| WasmModule.deserialize(Uint8List data) : this._(data, true); | |||
|
|
|||
| /// Asynchronously compile a module. | |||
| static Future<WasmModule> compileAsync(Uint8List data) async => | |||
| Future<WasmModule>(() => WasmModule(data)); | |||
There was a problem hiding this comment.
Suggested change
| Future<WasmModule>(() => WasmModule(data)); | |
| WasmModule(data); |
There was a problem hiding this comment.
The constructor I'm using here defers execution to a later time, but on the same isolate. My idea was that compilation/instantiation might be expensive, so although I can't do the compile on a different isolate, I can at least give the scheduler a chance to prioritize stuff like UI updates. It would be a bit weird to have an async method that can still block for a while.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
WasmModule.compileAsyncandWasmInstanceBuilder.buildAsync, so that the web API can be supported in the future.#34