This repository has been archived by the owner on Jan 20, 2018. It is now read-only.
fixes issue #27 #28
Merged
fixes issue #27 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately this will cause pretty bad performance regressions most likely :(. It is good to know though that the resolvers are where the deadlock is coming from. |
|
Actually, on second thought I think its probably worth submitting this for now and accept any possible performance hit since it at least gets things working. I will leave the other bug open though, as we should really try to find the root cause here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #27
I honestly don't know why this works, it was a bit trial and error for me. Maybe this gives other problems, but at least it solves issue #27 for me.