Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link hook to package:intl4x #866

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Add link hook to package:intl4x #866

wants to merge 18 commits into from

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Aug 14, 2024

Download datagen and data postcard files, and use them to link the static libraries.

This needs the new data asset loading feature to load the .postcard data, as well as record_use to tree-shake unused symbols from the library.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added type-infra A repository infrastructure change or enhancement package:intl4x labels Aug 14, 2024
@mosuem mosuem changed the base branch from main to stripSymbolsManually August 14, 2024 12:34
Copy link

github-actions bot commented Aug 14, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️
Package Version Status
package:intl 0.20.0-wip WIP (no publish necessary)
package:intl_translation 0.20.1-wip WIP (no publish necessary)
package:messages 0.2.0 already published at pub.dev
package:messages_builder 0.2.1 already published at pub.dev
package:messages_serializer 0.2.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem mosuem changed the base branch from stripSymbolsManually to main August 22, 2024 11:04
@github-actions github-actions bot removed the type-infra A repository infrastructure change or enhancement label Aug 22, 2024
@mosuem mosuem changed the title Add datagen support for intl4x Add link hook to package:intl4x Aug 22, 2024
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Aug 22, 2024
@mosuem mosuem marked this pull request as ready for review August 23, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:intl4x type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants