Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Found 1 file excluded from sound null safety #2274

Closed
Tracked by #49169
devoncarew opened this issue Jun 3, 2022 · 3 comments
Closed
Tracked by #49169

Found 1 file excluded from sound null safety #2274

devoncarew opened this issue Jun 3, 2022 · 3 comments

Comments

@devoncarew
Copy link
Member

devoncarew commented Jun 3, 2022 •
edited
Loading

Found 1 file excluded from sound null safety:

working/macros/example/bin/run.dart:5:// @dart=2.9

See dart-lang/sdk#49169 for more context.
@jakemac53
Copy link
Contributor

Fwiw, that file is blocked on package:frontend_server/compute_kernel.dart.

@devoncarew devoncarew mentioned this issue Jun 3, 2022
Closed
26 tasks
@devoncarew devoncarew changed the title Found 2 files excluded from sound null safety Found 1 file excluded from sound null safety Jun 3, 2022
@jakemac53
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/247601 will unblock this

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jun 9, 2022
@jakemac53
migrate package:frontend_server/compute_kernel.dart to null safety
4894ae4 
unblocks dart-lang/language#2274

Bug: #49212
Change-Id: I8d6b055dbc00dadce5efee57692ee1f21e8fde77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247601
Commit-Queue: Jake Macdonald <jakemac@google.com>
Auto-Submit: Jake Macdonald <jakemac@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jun 9, 2022
@jakemac53
Revert "migrate package:frontend_server/compute_kernel.dart to null s…
d7accf2 
…afety"

This reverts commit 4894ae4.

Reason for revert: Breaks google3

Original change's description:
> migrate package:frontend_server/compute_kernel.dart to null safety
>
> unblocks dart-lang/language#2274
>
> Bug: #49212
> Change-Id: I8d6b055dbc00dadce5efee57692ee1f21e8fde77
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247601
> Commit-Queue: Jake Macdonald <jakemac@google.com>
> Auto-Submit: Jake Macdonald <jakemac@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

TBR=johnniwinther@google.com,jakemac@google.com

Change-Id: I824374df31721fe60a08195b90f545e28460a982
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: #49212
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247760
Auto-Submit: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
@jakemac53
Copy link
Contributor

Fixed in a850f3c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakemac53 @devoncarew